Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(glog_component): prefix package and namespace with autoware #158

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 20, 2024

Description

Related links

autowarefoundation/autoware.universe#9302
autowarefoundation/autoware#5077
autowarefoundation/autoware#4569

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx self-requested a review December 4, 2024 11:58
@xmfcx xmfcx force-pushed the prefix-glog_component branch from 12ffa54 to acf5cee Compare December 4, 2024 11:58
@esteve esteve merged commit 209ee35 into autowarefoundation:main Dec 4, 2024
24 checks passed
@esteve esteve deleted the prefix-glog_component branch December 4, 2024 12:26
@xmfcx
Copy link
Contributor

xmfcx commented Dec 4, 2024

This was supposed to be merged along with others:

Was merged due to auto-merge.

@esteve
Copy link
Contributor Author

esteve commented Dec 4, 2024

@xmfcx oh, sorry, shall I submit a PR to revert these changes?

@esteve
Copy link
Contributor Author

esteve commented Dec 4, 2024

@xmfcx I've disabled auto-merge from the other PRs to prevent this happening again.

@xmfcx
Copy link
Contributor

xmfcx commented Dec 4, 2024

shall I submit a PR to revert these changes?

For now it's 🆗 since I am actively going to try to merge the others, compiling with everything checked out right now.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants